feat: add TabList#addEntries #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4drian3d
reviewed
Mar 29, 2023
api/src/main/java/com/velocitypowered/api/proxy/player/TabList.java
Outdated
Show resolved
Hide resolved
powercasgamer
commented
Mar 29, 2023
| void addEntries(Collection<TabListEntry> entries); | ||
|
|
||
| /** | ||
| * Adds an array of {@link TabListEntry}'s to the {@link Player}'s tab list. |
There was a problem hiding this comment.
Don't really like the word "array" here but couldn't come up with something better
4drian3d
reviewed
Mar 29, 2023
proxy/src/main/java/com/velocitypowered/proxy/tablist/KeyedVelocityTabList.java
Outdated
Show resolved
Hide resolved
4drian3d
approved these changes
Mar 29, 2023
kashike
requested changes
Apr 3, 2023
api/src/main/java/com/velocitypowered/api/proxy/player/TabList.java
Outdated
Show resolved
Hide resolved
powercasgamer
force-pushed
the
feat/tablist-add-entries
branch
from
4f4233b to
f3ca14b
Compare
powercasgamer
force-pushed
the
feat/tablist-add-entries
branch
from
f3ca14b to
4db040f
Compare
kashike
approved these changes
Aug 12, 2023
4drian3d
pushed a commit
to 4drian3d/Velocity
that referenced
this pull request
Sep 2, 2023
BlackBaroness
added a commit
to PvPClashnet/Velocity-CommandExecuteEvent
that referenced
this pull request
Oct 24, 2023
* Add version information for 1.20.1 (PaperMC#1021) * bump adventure to 4.14.0 (PaperMC#1034) * check if a plugin has a executor service (PaperMC#1038) * check if a plugin has an executor service * checkstyle * feat: add TabList#addEntries (PaperMC#987) * [ci skip] Replaced weired i with i in javadocs (PaperMC#1057) In this little patch I replaced an i which caused my build process to crash with an i * Do not track plugin channels registered per-player on the proxy (PaperMC#591) We don't need to track this information since Velocity uses the JoinGame packet, which is about as good of a server rejoin mechanism we're likely to get in vanilla Minecraft. * fix PaperMC#1062 * 1.20.2 Support (PaperMC#1088) Co-authored-by: RednedEpic <redned235@gmail.com> Co-authored-by: Gero <gecam59@gmail.com> * Actually send plugin message registration to backend servers I don't see where this was ever done, and don't see how plugin messaging could of ever worked, at least within the confines of CB and co, given the fact that we never seemed to be sending this to the backend? * appease checkstyle, move back to older fix placement * Change packet decode logging prompt * Catch throwables when loading plugins (PaperMC#1098) * Several improvements and fixes for 1.20.2 (PaperMC#1097) * Send LoginAcknowledged immediately * Resend player list header/footer after backend server switched to config state * Fix clearHeaderAndFooter not clearing fields in ConnectedPlayer * Clear boss bars, header/footer, tab list when switching client to config state * Send client settings in config state * Fix unsigned commands detected as signed (PaperMC#1082) * fix: commands flagged as signed without signed arguments * feat: improve error message for illegal protocol state. * acknowledge seen messages to server when running proxy commands (PaperMC#1100) * Implement ComponentLogger (PaperMC#1022) * Log the protocol phase in case of trying to obtain a packet id not existing in the phase (PaperMC#1107) * Bump netty to 4.1.100.Final (PaperMC#1067) --------- Co-authored-by: Pantera (Mad_Daniel) <89838384+Pantera07@users.noreply.github.com> Co-authored-by: chris <reichel32574@gmail.com> Co-authored-by: Aaron <71191102+RealBauHD@users.noreply.github.com> Co-authored-by: powercas_gamer <cas@deltapvp.net> Co-authored-by: Groldi <53694440+Plugrol@users.noreply.github.com> Co-authored-by: Andrew Steinborn <git@steinborn.me> Co-authored-by: Emmanuel Lampe <rexlmanude@gmail.com> Co-authored-by: Paul <Paul19988@users.noreply.github.com> Co-authored-by: RednedEpic <redned235@gmail.com> Co-authored-by: Gero <gecam59@gmail.com> Co-authored-by: Shane Freeder <theboyetronic@gmail.com> Co-authored-by: Joo200 <github@joo200.de> Co-authored-by: Adrian <68704415+4drian3d@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #958