Skip to content

Conversation

@Joo200
Copy link
Contributor

@Joo200 Joo200 commented Oct 12, 2023

This patch adds a custom payload handler in ServerGamePacketListenerImpl to handle cancelled commands and cancelled chat messages from the proxy.

My current implementation wraps the cancelled packet into a plugin message, protocol changes will be handled by the updated implementation in Minecraft code and Velocity.

This is a draft and can/should be used for PaperMC/Velocity#1100 and possible for Waterfall/BungeeCord.

@electronicboy
Copy link
Member

for a good while, I've wanted the means to "handshake" between the proxy and the server some form of capability -esque sysem, that way the proxy and the server can see if they support this stuff, i.e. we can detect if we're able to tell the server that chat cycled rather than just having to assume it based on proto version or whatever, but, I did kinda get veto'd on this, so, idk

@Joo200
Copy link
Contributor Author

Joo200 commented Oct 12, 2023

Yes, that's some open todo for velocity. For Paper it should be fine to listen to those plugin messages because there is no active logic that changes behavior.

Maybe we should just add it as config option to the velocity config and send that package then.

@Joo200 Joo200 marked this pull request as ready for review December 15, 2023 17:36
@Joo200 Joo200 requested a review from a team as a code owner December 15, 2023 17:36
@Joo200 Joo200 changed the title Draft: Use PluginMessage to allow Velocity to cancel signed chat and commands Use PluginMessage to allow Velocity to cancel signed chat and commands Jan 27, 2024
@Warriorrrr Warriorrrr moved this from Awaiting review to Waiting For Author in Paper PR Queue Mar 5, 2025
@kennytv kennytv added the pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch label Mar 23, 2025
@kennytv kennytv deleted the branch PaperMC:master March 23, 2025 19:15
@kennytv kennytv closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch pre-softspoon

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants