Add end portal creation to PortalCreateEvent#14093
Open
Biquaternions wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addesses #13832
This does not trigger for world generation (when the end portal generates with all eyes)
It also, at the moment of writing this, does not trigger for the end gateway and exit end portal, as those don't have straightforward access to the Entity that will trigger the portal creation.
See:
net.minecraft.world.level.levelgen.feature.EndGatewayFeaturenet.minecraft.world.level.levelgen.feature.EndPodiumFeatureCompared to:
net.minecraft.world.level.levelgen.feature.EndPlatformFeatureat L28net.minecraft.world.level.block.EndPortalBlockat L100