Skip to content

Implement deprecated getItemStack method in ItemTypeRecipeChoice #13607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennytv merged 2 commits into from
Feb 6, 2026
+13 −1
Merged

Implement deprecated getItemStack method in ItemTypeRecipeChoice #13607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe5fbfb
Implement deprecated getItemStack in ItemTypeRecipeChoice
Warriorrrr Feb 5, 2026
fb9b1e4
Use item registry constant
Warriorrrr Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions paper-api/src/main/java/org/bukkit/inventory/EmptyRecipeChoice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ record EmptyRecipeChoice() implements RecipeChoice {

static final RecipeChoice INSTANCE = new EmptyRecipeChoice();
@Override
@Deprecated(since = "1.13.1")
public ItemStack getItemStack() {
throw new UnsupportedOperationException("This is an empty RecipeChoice");
}
Expand Down
11 changes: 10 additions & 1 deletion paper-api/src/main/java/org/bukkit/inventory/ItemTypeRecipeChoiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,17 @@ final class ItemTypeRecipeChoiceImpl extends RecipeChoice.MaterialChoice impleme
}

@Override
@Deprecated(since = "1.13.1")
public ItemStack getItemStack() {
throw new UnsupportedOperationException("ItemTypeChoice does not support this");
final ItemType type = Registry.ITEM.getOrThrow(this.itemTypes.iterator().next());
final ItemStack item = type.createItemStack();

// legacy compat
if (this.itemTypes.size() > 1) {
item.setDurability(Short.MAX_VALUE);
}

return item;
}

@Override
Expand Down
2 changes: 2 additions & 0 deletions paper-api/src/main/java/org/bukkit/inventory/RecipeChoice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ public boolean test(ItemStack t) {
}

@Override
@Deprecated(since = "1.13.1")
public ItemStack getItemStack() {
ItemStack stack = new ItemStack(choices.get(0));

Expand Down Expand Up @@ -247,6 +248,7 @@ public ExactChoice(List<ItemStack> choices) {
}

@Override
@Deprecated(since = "1.13.1")
public ItemStack getItemStack() {
return choices.get(0).clone();
}
Expand Down
Loading