Move MenuType API to utilize true fake BlockEntity's #13439
+15
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
from
5badd3e to
9b5dcec
Compare
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
from
a1eec90 to
febd434
Compare
Y2Kwastaken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we handle fake BlockEntity instances by no longer assigning them a Level/world. Instead of faking placement, we apply a small, targeted set of null-safety patches to ensure that server logic does not NPE when interacting with these fake block entities.
Previously, fake BlockEntity instances were given the player's world to get around internal assumptions. While somewhat functional, this caused some nasty unintended side effects around placement state, event broadcasting, and redstone/game events. The goal here is to keep fake block entities truly unplaced, while still allowing safe interaction paths where needed.
Largely this is cleanup, I highly encourage testing because this edits a pretty critical portion of the builder code even though it was only a few lines.
Fixes #13438