Restore vanilla non-player teleports #12801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
With this also cover this #12737 not? because now the teleport api calls the teleport and not just the snapTo and if true then can close my PR https://github.com/PaperMC/Paper/pull/12740/files i think |
Member
|
That flag needs to be removed. It's not supposed to have the behavior that the PR is doing. |
Member
|
It doesn't do anything anymore |
|
Hey guys, sorry to bother is this something that can be merged, pushed upwards ? It has been broken for many version now, and would love to fix teleporting on my server. Thank you! |
Comment on lines
+325
to
+326
| location.getPitch(), | ||
| location.getYaw(), |
Contributor
There was a problem hiding this comment.
I'm pretty sure those two are inverted
Member
|
Superceded by #13181 |
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces https://github.com/PaperMC/Paper/pull/10734/files
Restores more vanilla-like logic for non-player teleports. Player's will be handled later, as well as changing the default behavior of api teleport methods to include passengers by default.
Also makes relative velocity flags work for teleporting entities.