Skip to content

Brigadier sorting performance #3154

Closed
Closed

Description

Timings or Profile link:

https://spark.lucko.me/?CgSlYGCVq7

Description of issue:

Brigadier is sorting nodes every time a child is added as seen here. This was tested on 1.13.2 but this likely is still an issue in the newest version. I believe that this issue is somewhat resolved due to #3116 but it could still be useful. This issue seems to be resolved by deleting the sorting line and making the children map a TreeMap. The issue occurs on login or world switch and may be related to previous issues discussed. This fix has been on a production server for a month with no noticeable issues. Not sure how reproducible this will be on the latest builds due to #3116 but let me know if I should try to reproduce this on a newer version.

Plugin list:

Plugins (11): CountryFlags*, DynamicScoreboard*, Essentials*, EssentialsChat*, EssentialsSpawn*, LuckPerms*, ObbyLang*, PandaWire, PlaceholderAPI, RedstonePatch, spark*

bukkit.yml, spigot.yml, paper.yml, server.properties

Default

Other helpful links

Spark after the patch is applied: https://spark.lucko.me/?I7HW1n2Xll

Paper build number:

655 (MC: 1.13.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions