fix: Unused vars causing build error #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses TypeScript compilation errors in the chrome extension build by removing unused variables and parameters. The changes clean up the JsonRpc component and its usage by eliminating the unused jsonRpcResult parameter and associated unused imports.
Key changes:
- Removed
jsonRpcResultprop fromJsonRpccomponent interface and implementation - Cleaned up unused imports (
JsonRpcResult,MarkdownComponent,useState) from jsonrpc.tsx - Updated all
JsonRpccomponent invocations to exclude thejsonRpcResultparameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| webapp/_webapp/src/components/message-entry-container/tools/tools.tsx | Removed jsonRpcResult parameter from two JsonRpc component calls |
| webapp/_webapp/src/components/message-entry-container/tools/jsonrpc.tsx | Removed unused imports and jsonRpcResult from component props interface and implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused vars that is causing the chrome extension build error due to TypeScript's strict compilation rules.