chore: disable-beta-feature #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables beta feature settings in the application and applies code formatting improvements across multiple files. The main functional change removes the BetaFeatureSettings component from the settings page, while the remaining changes are purely cosmetic formatting updates to improve code consistency.
- Removed BetaFeatureSettings component from settings page
- Applied consistent formatting to JSX elements (proper indentation and line breaks)
- Cleaned up whitespace and quote style inconsistencies
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webapp/_webapp/src/views/settings/index.tsx | Removed BetaFeatureSettings import and component usage |
| webapp/_webapp/src/views/login/index.tsx | Reformatted JSX with consistent indentation and parentheses placement |
| webapp/_webapp/src/libs/overleaf-socket.ts | Removed trailing whitespace |
| webapp/_webapp/src/index.css | Removed blank line before Chinese comment |
| webapp/_webapp/src/components/message-entry-container/tools/utils/common.tsx | Reformatted with consistent indentation and double quotes |
| webapp/_webapp/src/components/message-entry-container/tools/tools.tsx | Improved JSX formatting with multi-line prop placement |
| webapp/_webapp/src/components/message-entry-container/tools/jsonrpc.tsx | Reformatted JSX elements with consistent indentation and structure |
| webapp/_webapp/src/components/loading-indicator.tsx | Split long conditional return statement across multiple lines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (jsonRpcResult) { | ||
| return <JsonRpc functionName={functionName} jsonRpcResult={jsonRpcResult} preparing={preparing} animated={animated} />; | ||
| return ( | ||
| <JsonRpc functionName={functionName} jsonRpcResult={jsonRpcResult} preparing={preparing} animated={animated} /> |
There was a problem hiding this comment.
[nitpick] Inconsistent JSX formatting: This line should be formatted across multiple lines like the similar JSX element above (lines 49-56) for consistency.
Suggested change
| <JsonRpc functionName={functionName} jsonRpcResult={jsonRpcResult} preparing={preparing} animated={animated} /> | |
| <JsonRpc | |
| functionName={functionName} | |
| jsonRpcResult={jsonRpcResult} | |
| preparing={preparing} | |
| animated={animated} | |
| /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Removes the beta settings import and performs small UI/JSX cleanups across tools and login components.
BetaFeatureSettingsimport inviews/settings/index.tsx.components/message-entry-container/tools/jsonrpc.tsx; minor prop formatting intools.tsx.loading-indicator.tsxandviews/login/index.tsx.index.cssandlibs/overleaf-socket.ts.Written by Cursor Bugbot for commit 81a4220. This will update automatically on new commits. Configure here.