Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC404.sol - transferFrom returns bool to match erc20 standard #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ERC404.sol - transferFrom returns bool to match erc20 standard #10

wants to merge 1 commit into from

Conversation

encloinc
Copy link

As defined by the ERC20 standard, transferFrom returns "bool" to identify whether the transaction was successful or not.

  • ERC404 not having this makes it uncompatible with a lot of DAPPs.

This PR fixes this.

@encloinc encloinc changed the title transferFrom returns bool to match erc20 standard Update ERC20.sol - transferFrom returns bool to match erc20 standard Feb 13, 2024
@encloinc encloinc changed the title Update ERC20.sol - transferFrom returns bool to match erc20 standard Update ERC404.sol - transferFrom returns bool to match erc20 standard Feb 13, 2024
Patoski3
Patoski3 approved these changes Feb 15, 2024
View reviewed changes
Copy link

@Patoski3 Patoski3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reverts happened so transaction was successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patoski3 Patoski3 Patoski3 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encloinc @Patoski3