-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor nrm #114
Merged
Merged
WIP: Refactor nrm #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1、tap测试是没有问题 |
|
功能是类似的,可读性上是有差异的。另外我理解coffee对跨平台做了很多兼容。 tap的mock功能我还没看到,https://github.com/tapjs/node-tap/blob/main/package.json#L22依赖有点多。 先合并,一点点优化吧 |
OK,谢狼叔指点。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Work In Progress merge request, CAN NOT merge directly now.
Motivation
When I tried to add some test cases for
cli.js
, I found some test cases will run fail for some reason, for example,npm.config.get('registry')
will get a wrong registry(https://registry.yarnpkg.com/
) sometimes, I am sure about that the registry(https://registry.yarnpkg.com/
) does not exist in any related configuration file.In addition, use
npm
lib to write.npmrc
file is unnecessary,fs.writeFileSync
is enough. And the programmatic API was removed innpm
from v8.0.0, as we can see inindex.js
, so, thevar npm = require('npm')
usage is not recommended and already has been deprecated.I will do
npm
dependencyrequest
withnode-fetch