fix: remove unnecessary if condition #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
nrm ls
andnrm current
can not display the current registry.Bug
hasOwnProperty(customRegistries, name)
is alwaysfalse
afternrm use taobao
(for example), so the statementregistry[FIELD_IS_CURRENT] = true;
can not be executed forever.Description
name in allRegistries
is already judged in L186,allRegistry
includecustomRegistry
andregistries
, so theif
condition in L211 is unnecessary.Fix: #101
Fix: #109
Fix: #110