[bugfix] Ensure 0 and false are guarded correctly and add deprecated support to params #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +214 B (0%) Total Size: 6.34 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit bceb927): https://docusaurus-openapi-36b86--pr754-7ghqd73i.web.app (expires Fri, 19 Apr 2024 14:30:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
added a commit
that referenced
this pull request
Mar 20, 2024
…support to params (#754) * avoid guarding 0 values * support deprecated params * update utils tests to should guard false * always render required when true and apply strikethrough when deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
guardto allow0valuesfalsevalues are properly guardeddeprecatedis supported for paramsMotivation and Context
Addresses regression bug introduced in #725
How Has This Been Tested?
All utils tests passed as expected:
PASS packages/docusaurus-theme-openapi-docs/src/markdown/utils.test.ts
Performed spot check by comparing rendered output of plugin with Redocly