Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markdown pages heading creation #716

Conversation

lucasassisrosa
Copy link
Contributor

@lucasassisrosa lucasassisrosa commented Feb 2, 2024

Description

Normalize @theme/Heading component usage

Motivation and Context

Due to headings creation using html elements, some headings didn't have classnames or had different classnames across the markdown pages. This was preventing or making more difficult to customize styles when using this library

How Has This Been Tested?

Check the following pages Headings H1 and H2:

  • Go to /petstore/swagger-petstore-yaml and check Swagger Petstore YAML, Authentication
  • Go to /petstore/subscribe-to-the-store-events and check Request, Responses, Callbacks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link

github-actions bot commented Feb 2, 2024

Visit the preview URL for this PR (updated for commit f17dc07):

https://docusaurus-openapi-36b86--pr716-siyzke7b.web.app

(expires Thu, 11 Apr 2024 13:39:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata
Copy link
Member

Looks good - do you think this is something we should/could back port to v2?

@sserrata sserrata merged commit d7b4b64 into PaloAltoNetworks:v3.0.0 Mar 12, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants