-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: markdown pages heading creation #716
Merged
sserrata
merged 5 commits into
PaloAltoNetworks:v3.0.0
from
lucasassisrosa:fix-markdown-pages-heading-creation
Mar 12, 2024
Merged
fix: markdown pages heading creation #716
sserrata
merged 5 commits into
PaloAltoNetworks:v3.0.0
from
lucasassisrosa:fix-markdown-pages-heading-creation
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasassisrosa
temporarily deployed
to
default
February 2, 2024 01:08
— with
GitHub Actions
Inactive
lucasassisrosa
commented
Feb 2, 2024
packages/docusaurus-plugin-openapi-docs/src/markdown/createAuthentication.ts
Show resolved
Hide resolved
lucasassisrosa
commented
Feb 2, 2024
Visit the preview URL for this PR (updated for commit f17dc07): https://docusaurus-openapi-36b86--pr716-siyzke7b.web.app (expires Thu, 11 Apr 2024 13:39:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
reviewed
Feb 5, 2024
packages/docusaurus-plugin-openapi-docs/src/markdown/createRequestHeader.ts
Show resolved
Hide resolved
lucasassisrosa
had a problem deploying
to
default
February 5, 2024 17:08
— with
GitHub Actions
Failure
sserrata
approved these changes
Mar 12, 2024
Looks good - do you think this is something we should/could back port to v2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normalize
@theme/Heading
component usageMotivation and Context
Due to headings creation using html elements, some headings didn't have classnames or had different classnames across the markdown pages. This was preventing or making more difficult to customize styles when using this library
How Has This Been Tested?
Check the following pages Headings H1 and H2:
Swagger Petstore YAML
,Authentication
Request
,Responses
,Callbacks
Types of changes
Checklist