-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem?
Yes.
I know that it's possible to set deploymentSecret.create as false to use Vault sidecar which will inject a file with distribution-id in it.
However if CSI or External Secrets Operator is used to work with Secrets in a cluster, there's no way how to provide distribution-id to the Cortex agent Pod.
Describe the solution you'd like
- Add
daemonset.annotationstodaemonset.yaml- This will allow to use tools like Reloader where a special annotation on a DaemonSet will make it watch change to Secret created by the chart (or externally) and recreate Pods.
- ExternalSecrets object will populate a proper
distribution-idto a Secret created by the chart withdeploymentSecret.create: true, however all Pods will need to be recreated to fetch that change.
Alternative (additional) solutions are:
- Add
daemonset.extraVolumesanddaemonset.extraVolumeMounts- This will allow to set
deploymentSecret.create: falseand use CSI drivers supplying custom Secret objects, created on a side
- This will allow to set
- Add support for
deploymentSecret.nameto work similar asdockerPullSecret.name- This will allow to set deploymentSecret.create: false
and provide name for any other Secret object containingdistribution-id` created externally.
- This will allow to set deploymentSecret.create: false
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request