-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Merge conflict with the develop branch #926
Fixed Merge conflict with the develop branch #926
Conversation
Updated CODE_STYLE.md
…n#916) * added linting rules * added linting rules * added linting rules
…tion#829] (PalisadoesFoundation#835) * Refactor screens * Update components * Fix test * Fix typecheck errors * Increase test coverage
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov Report
@@ Coverage Diff @@
## adminUI-redesign #926 +/- ##
====================================================
+ Coverage 92.95% 93.01% +0.05%
====================================================
Files 65 65
Lines 1462 1488 +26
Branches 371 377 +6
====================================================
+ Hits 1359 1384 +25
- Misses 98 99 +1
Partials 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The latest develop branch is merged into adminUI-redesign branch, I have fixed all the merge conflicts, now please merge this PR. After this PR is merged I will open another PR, to merge my develop branch (which had my adminUI-redesign merged into it) into organization's develop branch. The unauthorized file change error is because another contributor had modified |
@anwersayeed @muskan399 Please review |
What kind of change does this PR introduce?
Migration of Bootstrap 4 to 5
Removal of redundant libraries such as Popper.js and React-Modal
Migration of components from plain html to components imported from Bootstrap 5
Issue Number:
Fixes None
Did you add tests for your changes?
Yes
Snapshots/Videos:
None
If relevant, did you update the documentation?
No
Summary
Migration and removal of redundant libraries.
Does this PR introduce a breaking change?
Class based modals wont work from now, other than that no breaking change.
Other information
Have you read the contributing guide?
Yes