Fixes: Translations Are Not Correctly Tested in Our PR Workflow #2263
Conversation
WalkthroughThe pull request introduces a new function, Changes
Assessment against linked issues
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Created a separate issue to sync the translations. |
Okay sure |
Nandika-A
dismissed stale reviews from pranshugupta54 and coderabbitai[bot]
via
c093346
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- public/locales/en/translation.json (38 hunks)
Additional comments not posted (7)
public/locales/en/translation.json (7)
26-43: The additions to the "loginPage" section look good!The new key-value pairs follow a consistent naming convention, have appropriate values, and align well with the context of the login page.
88-91: The additions to the "listNavbar" section are appropriate.The new key-value pairs in the "listNavbar" section have concise and descriptive keys, and the values are suitable for navigation items.
96-100: The additions to the "leftDrawer" section look good.The new key-value pairs in the "leftDrawer" section have clear and contextual keys, and the values are appropriate for menu items in a left drawer.
119-125: The additions to the "leftDrawerOrg" section are appropriate.The new key-value pairs in the "leftDrawerOrg" section have contextual keys related to organization-specific items, and the values are suitable for their respective purposes.
155-167: The additions to the "orgList" section look good.The new key-value pairs in the "orgList" section have descriptive keys that provide clear context for organization list-related functionalities. The values are appropriate and align well with their respective keys.
171-173: The additions to the "orgListCard" section are appropriate.The new key-value pairs in the "orgListCard" section have concise and descriptive keys, and the values are suitable for their respective purposes.
Line range hint
1-1156: Overall, the additions to the translation file look good!The new key-value pairs added across different sections of the file follow consistent naming conventions, have appropriate values, and align well with their respective contexts. The changes enhance the localization capabilities of the application.
Just one suggestion: Consider merging the "loginPage" and "userLoginPage" sections to avoid duplication and maintain consistency.
Great job with the translations!
|
Yes, two of the files were missing some translations. I have added them and no other translations are remaining now. Could you please review them? |
|
Please fix the failing tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2263 +/- ##
========================================
Coverage 97.54% 97.54%
========================================
Files 241 241
Lines 6883 6887 +4
Branches 2001 2005 +4
========================================
+ Hits 6714 6718 +4
Misses 157 157
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
Hi @palisadoes ! I have made all the changes, could you please review them? |
palisadoes
merged commit e143243
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Issue Number:
Fixes #2260
Did you add tests for your changes?
No
Snapshots/Videos:
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Bug Fixes