[organization] updated organization screen #2085
Conversation
filtered out events from action items and created unit test to verify only action items are being displayed
WalkthroughThe changes filter out event-specific action items from the organization-wide action items screen. A new mock action item is added, and a test case ensures only organization action items are displayed. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- src/screens/OrganizationActionItems/OrganizationActionItemMocks.ts (1 hunks)
- src/screens/OrganizationActionItems/OrganizationActionItems.test.tsx (1 hunks)
- src/screens/OrganizationActionItems/OrganizationActionItems.tsx (2 hunks)
Additional context used
Learnings (2)
Common learnings
Learnt from: Chaitanya1672 PR: PalisadoesFoundation/talawa-admin#2049 File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138 Timestamp: 2024-07-03T07:40:16.065Z Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.src/screens/OrganizationActionItems/OrganizationActionItems.test.tsx (1)
Learnt from: Chaitanya1672 PR: PalisadoesFoundation/talawa-admin#2049 File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138 Timestamp: 2024-07-03T07:40:16.065Z Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Additional comments not posted (4)
src/screens/OrganizationActionItems/OrganizationActionItemMocks.ts (1)
99-127: New action item added to mock data.The new action item is consistent with the existing structure and aligns with the PR objectives to filter out event action items.
src/screens/OrganizationActionItems/OrganizationActionItems.tsx (2)
200-202: New filter logic added to exclude event action items.The new filter logic correctly excludes action items associated with events by checking if
item.eventis null.
372-372: Updated prop passed toActionItemsContainer.The updated prop
actionItemsDatanow uses the filtered action items, ensuring only non-event action items are passed.src/screens/OrganizationActionItems/OrganizationActionItems.test.tsx (1)
598-618: New test case added to verify that only organization action items are displayed.The new test case checks for the presence of an action item named "John Doe", which is part of the mock data with
eventset to null. This aligns with the PR objectives.
|
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2085 +/- ##
========================================
Coverage 97.91% 97.92%
========================================
Files 231 231
Lines 6201 6203 +2
Branches 1790 1790
========================================
+ Hits 6072 6074 +2
Misses 118 118
Partials 11 11 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
bugFix, and Unit Test
Issue Number:
Fixes #2058
Did you add tests for your changes?
Yes
Summary
Filtered out events from action items and created unit test to verify only action items are being displayed.
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Bug Fixes
Tests