Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package typescript from 5.6.2 to 5.6.3 #2334

Closed
palisadoes opened this issue Oct 14, 2024 · 8 comments
Closed

Upgrade package typescript from 5.6.2 to 5.6.3 #2334

palisadoes opened this issue Oct 14, 2024 · 8 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade the package
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs and Tests

@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers security Security fix dependencies Pull requests that update a dependency file labels Oct 14, 2024
@CHIRANTH-24
Copy link

@palisadoes could you please assign this to me?

@mandeepnh5
Copy link

@palisadoes can you please assign to me

@Anusha-pannati
Copy link

@palisadoes can you assign this issue to me

@varshith257
Copy link
Member

@Anusha-pannati @mandeepnh5 Thanks for your enthusiasm to contribute. I have assigned to the one first commented. I think are many open good first issues. Have a look and ask to assign

@CHIRANTH-24
Copy link

@varshith257, when i run "npm run lint:check", im getting ths :

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.3

Please only submit bug reports when using the officially supported version.

Do i create PR with this error?

@varshith257
Copy link
Member

Submit PR, you can get lint fails if any in the workflow

@CHIRANTH-24
Copy link

@varshith257
Could you please review it once

@CHIRANTH-24
Copy link

CHIRANTH-24 commented Oct 18, 2024

Thank you for reviewing @varshith257 and @palisadoes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix
Projects
None yet
Development

No branches or pull requests

5 participants