Test for ambiguities? #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. I think it makes sense to have this test if it also enforces that there are no ambiguities, just printing them doesn't encourage too much to fix them 🙂 |
|
I fixed a few, not sure I understand the package well enough to fix all of them, nor to know whether they can ever matter in practice. So maybe this is more an issue than a PR for now. It could perhaps test |
sostock
reviewed
Jan 4, 2022
| @@ -191,6 +191,7 @@ for (_x,_y) in [(:fma, :_fma), (:muladd, :_muladd)] | |||
| # Catch some signatures pre-promotion | |||
| @eval @inline ($_x)(x::Number, y::AbstractQuantity, z::AbstractQuantity) = ($_y)(x,y,z) | |||
| @eval @inline ($_x)(x::AbstractQuantity, y::Number, z::AbstractQuantity) = ($_y)(x,y,z) | |||
| @eval @inline ($_x)(x::AbstractQuantity, y::AbstractQuantity, z::AbstractQuantity) = ($_y)(x,y,z) | |||
There was a problem hiding this comment.
Adding this method means that the one below it can be deleted (it’s the same but with unused type parameters).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs
detect_ambiguities, but doesn't (yet) demand the result be empty.Here's the list it prints out: https://github.com/PainterQubits/Unitful.jl/pull/439/checks?check_run_id=2367869650#step:6:35