make assignment work on ustrip'ed StridedArrays

PainterQubits · Apr 18, 2023 · 41f6b78 · 41f6b78
1 parent 4ce89e1
commit 41f6b78
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/utils.jl b/src/utils.jl
@@ -75,7 +75,7 @@ julia> a[1] = 3u"m"; b
  2
 ```
 """
-@inline ustrip(A::Array{Q}) where {Q <: Quantity} = reinterpret(numtype(Q), A)
+@inline ustrip(A::StridedArray{Q}) where {Q <: Quantity} = reinterpret(numtype(Q), A)
 
 @deprecate(ustrip(A::AbstractArray{T}) where {T<:Number}, ustrip.(A))
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1425,6 +1425,10 @@ end
                 Tridiagonal{Int}
             @test typeof(ustrip(SymTridiagonal([1,2,3]u"m", [4,5]u"m"))) <:
                 SymTridiagonal{Int}
+            A = zeros(3,3)*1u"s"
+            V = view(A,2:3,2:3)
+            ustrip(V)[1,1]=1
+            @test A[2,2] == 1u"s"
         end
         @testset ">> Linear algebra" begin
             @test istril(1m) === true