Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing properties to incident_custom_field resource documentation #751

Conversation

jedelson-pagerduty
Copy link
Contributor

@jedelson-pagerduty jedelson-pagerduty commented Sep 29, 2023

It appears that in executing the series of changes related to the incident_custom_field resource, the documentation ended up in a state where a subset of properties were omitted. Of chief import is that the display_name property is not documented -- this is required and thus really important to have documented correctly.

Closes #767

@jedelson-pagerduty
Copy link
Contributor Author

@imjaroiswebdev FYI - this is a purely docs change. Not sure if there is a way to publish this without doing a formal release.

@imjaroiswebdev imjaroiswebdev force-pushed the issue/correct-custom-fields-documentation branch from 290bbb8 to c19de50 Compare November 15, 2023 15:13
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jedelson-pagerduty thank you for adding this necessary update to the docs. I took the liberty of rebasing your changes for a clean merge btw ✌🏽

@imjaroiswebdev imjaroiswebdev merged commit 03bf1b9 into PagerDuty:master Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagerduty_incident_custom_field display_name attrib not documented
2 participants