[ORCA-3999] Add EOL banner to Ruleset and Service Rules #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyurina
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
I've gone back and forth on whether we should link to the KB article or the Orchestration TF resources instead.
But since the KB article has the actual EOL date, and also links to the TF provider I think the KB article is preferred. I will also post in the TF channel to see if Jose would like to review
imjaroiswebdev
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Great @alexzakabluk! I really liked how you hacked out the html tags to show a warning block. Dope! For me this looks pretty good in form and content 🎉 👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added a banner message with EOL information to the terraform documentation for rulesets and service rules: