Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EF-3964 Address team_membership inconsistency after create and update #621

Merged

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Jan 25, 2023

Addresses the issue with pagerduty_team_membership that causes a permanent diff on TF state with the user role. So now the introduction of a few conditional retries to the GET call to validate the change when needed, the state diff can be remediated.

Test cases introduced...

Screenshot 2023-01-25 at 17 26 42

@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review January 25, 2023 20:41
Copy link
Contributor

@johncoleman83 johncoleman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great!

@imjaroiswebdev imjaroiswebdev changed the title Address team_membership unconsistency after create and update Address team_membership inconsistency after create and update Jan 26, 2023
@imjaroiswebdev imjaroiswebdev changed the title Address team_membership inconsistency after create and update EF-3964 Address team_membership inconsistency after create and update Jan 26, 2023
@imjaroiswebdev imjaroiswebdev merged commit 1ea3c9e into PagerDuty:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants