Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the update operation on pagerduty_automation_actions_action and pagerduty_automation_actions_runner #603

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

mrdubr
Copy link
Contributor

@mrdubr mrdubr commented Dec 21, 2022

Add support for the update operation on pagerduty_automation_actions_action and pagerduty_automation_actions_runner

Updated test cases:

$ make testacc TESTARGS="-run TestAccPagerDutyAutomationActionsAction*"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyAutomationActionsAction* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-pagerduty	[no test files]
=== RUN   TestAccPagerDutyAutomationActionsActionTeamAssociation_import
--- PASS: TestAccPagerDutyAutomationActionsActionTeamAssociation_import (11.04s)
=== RUN   TestAccPagerDutyAutomationActionsAction_import
--- PASS: TestAccPagerDutyAutomationActionsAction_import (8.72s)
=== RUN   TestAccPagerDutyAutomationActionsActionTeamAssociation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTeamAssociation_Basic (8.64s)
=== RUN   TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic (11.33s)
=== RUN   TestAccPagerDutyAutomationActionsActionTypeScript_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTypeScript_Basic (9.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	49.654s
$ make testacc TESTARGS="-run TestAccPagerDutyAutomationActionsRunner*"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyAutomationActionsRunner* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-pagerduty	[no test files]
=== RUN   TestAccPagerDutyAutomationActionsRunner_import
--- PASS: TestAccPagerDutyAutomationActionsRunner_import (7.55s)
=== RUN   TestAccPagerDutyAutomationActionsRunner_Basic
--- PASS: TestAccPagerDutyAutomationActionsRunner_Basic (9.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	17.551s

Depends on: heimweh/go-pagerduty#111

@mrdubr mrdubr changed the title Avg.rdc 997 Add support for the update operation on pagerduty_automation_actions_action Dec 21, 2022
@mrdubr mrdubr marked this pull request as ready for review December 21, 2022 14:42
@mrdubr mrdubr marked this pull request as draft December 22, 2022 17:20
@mrdubr mrdubr changed the title Add support for the update operation on pagerduty_automation_actions_action Add support for the update operation on pagerduty_automation_actions_action and pagerduty_automation_actions_runner Dec 22, 2022
@mrdubr mrdubr marked this pull request as ready for review December 22, 2022 17:23
@mrdubr mrdubr force-pushed the avg.RDC-997 branch 2 times, most recently from 4bfd996 to ab36e86 Compare January 4, 2023 17:28
@imjaroiswebdev imjaroiswebdev self-requested a review January 5, 2023 21:47
go.mod Outdated Show resolved Hide resolved
go mod edit -dropreplace github.com/heimweh/go-pagerduty
go get github.com/heimweh/go-pagerduty/pagerduty && go mod tidy && go mod vendor
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! From here and on Users will be able to update these resources without having to do a full replace of them. Awesome @mrdubr 🎉 💪🏽

@imjaroiswebdev imjaroiswebdev merged commit ac35481 into PagerDuty:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants