Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address: pagerduty_service.alert_grouping_parameters.config block parsing #570

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

imjaroiswebdev
Copy link
Contributor

Address #550

This update is aimed to correctly handle the parsing for pagerduty_service.alert_grouping_paramerts.config block.

Test results...
Screen Shot 2022-09-15 at 17 29 16

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Are there any changes that need to be made to the documentation because of this change?

@imjaroiswebdev
Copy link
Contributor Author

It's great that you point this out @stmcallister, because the issue being addressed by this PR is happening because the current implementation doesn't stick to the documented API when it has to do with updating pagerduty_service.alert_grouping_parameters configurations, and now with this update the Provider will able to consistently create and update pagerduty_service.alert_grouping_parameters resource configurations.

@davidpellcb
Copy link

davidpellcb commented Oct 6, 2022

Hi all, found this PR through various googling. We're currently way behind on our provider version (2.1.1) but seeing constant unnecessary diffs in our plans that look like this for every single service that uses alerting_group_parameters with type = "intelligent":

image

We see the same issue when testing with 2.6.2.

However, if we actually use config: [] in the alerting_group_parameters we get an error:

image

I believe this is because config isn't meant to be used with type = "intelligent" based on the docs:

image

Not sure if this is an issue with the PD API or the TF provider. Also unsure from reading the PR description if this will address our issue. Do I need to open a separate issue?

@imjaroiswebdev
Copy link
Contributor Author

Hi @davidpellcb the issue you are facing with your config is more related to the syntax, because your are trying to declare an Attribute named config, instead of a config block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants