Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input validation and drift detection during deletion for service_dependency #530

Merged

Conversation

imjaroiswebdev
Copy link
Contributor

Address: #526

Documentation improvement:

Dependency supporting and dependent service supports the following:

  • id - (Required) The ID of the service dependency.
  • type - (Required) Can be business_service or service.

Tests results...
Screen Shot 2022-06-16 at 16 57 45

@imjaroiswebdev imjaroiswebdev marked this pull request as draft June 16, 2022 21:33
@imjaroiswebdev imjaroiswebdev changed the title add input validation for service_dependency type add input validation and drift detection during deletion for service_dependency Jun 29, 2022
@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review June 29, 2022 01:30
@imjaroiswebdev imjaroiswebdev force-pushed the issue-526-v2-5-1-plugin-crashing branch from af954f0 to b649442 Compare July 11, 2022 21:41
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it!! 👍 🎉 🌮

@stmcallister stmcallister merged commit 447d228 into PagerDuty:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants