Address: Unable to switch off alert grouping on a service #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjaroiswebdev
force-pushed
the
issue-520-uable-swoff-alert-grouping
branch
from
0714106
to
6b59244
Compare
stmcallister
approved these changes
Jun 17, 2022
pdecat
reviewed
Jun 20, 2022
| "pagerduty_service.foo", "incident_urgency_rule.0.type", "constant"), | ||
| ), | ||
| ExpectNonEmptyPlan: true, | ||
| }, |
There was a problem hiding this comment.
I believe this should not be used in this test. It prevents detecting changes in the API response from what is expected.
| resource.TestCheckResourceAttr( | ||
| "pagerduty_service.foo", "alert_grouping", "rules"), | ||
| resource.TestCheckNoResourceAttr( | ||
| "pagerduty_service.foo", "alert_grouping_parameters.0.config"), |
There was a problem hiding this comment.
I believe this check does not work as expected. Newer versions of the terraform SDK reject this:
=== RUN TestAccPagerDutyService_AlertContentGrouping
resource_pagerduty_service_test.go:206: Step 2/2 error: Check failed: Check 8/12 error: pagerduty_service.foo: list or set attribute 'alert_grouping_parameters.0.config' must be checked by element count key (alert_grouping_parameters.0.config.#) or element value keys (e.g. alert_grouping_parameters.0.config.0). Set element value checks should use TestCheckTypeSet functions instead.
--- FAIL: TestAccPagerDutyService_AlertContentGrouping (13.98s)
See #525 (comment)
Changing it to the recommended way reveals an issue:
diff --git a/pagerduty/resource_pagerduty_service_test.go b/pagerduty/resource_pagerduty_service_test.go
index 7cda1e3d..dceef04a 100644
--- a/pagerduty/resource_pagerduty_service_test.go
+++ b/pagerduty/resource_pagerduty_service_test.go
@@ -254,8 +254,8 @@ func TestAccPagerDutyService_AlertContentGrouping(t *testing.T) {
"pagerduty_service.foo", "alert_creation", "create_alerts_and_incidents"),
resource.TestCheckResourceAttr(
"pagerduty_service.foo", "alert_grouping", "rules"),
- resource.TestCheckNoResourceAttr(
- "pagerduty_service.foo", "alert_grouping_parameters.0.config"),
+ resource.TestCheckResourceAttr(
+ "pagerduty_service.foo", "alert_grouping_parameters.0.config.#", "0"),
resource.TestCheckResourceAttr(
"pagerduty_service.foo", "alert_grouping_parameters.0.type", ""),
resource.TestCheckResourceAttr(
=>
make testacc TEST=./pagerduty/ TESTARGS='-run=TestAccPagerDutyService_AlertContentGrouping'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty/ -v -run=TestAccPagerDutyService_AlertContentGrouping -timeout 120m
=== RUN TestAccPagerDutyService_AlertContentGrouping
resource_pagerduty_service_test.go:206: Step 2/2 error: Check failed: Check 8/12 error: pagerduty_service.foo: Attribute 'alert_grouping_parameters.0.config.#' expected "0", got "1"
--- FAIL: TestAccPagerDutyService_AlertContentGrouping (14.80s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-pagerduty/pagerduty 14.813s
FAIL
make: *** [GNUmakefile:17: testacc] Error 1
There was a problem hiding this comment.
Submitted #532 to replicate the issue.
There was a problem hiding this comment.
The new terraform SDK check comes from hashicorp/terraform-plugin-sdk#920 which was released in https://github.com/hashicorp/terraform-plugin-sdk/blob/v2.13.0/CHANGELOG.md#2130-march-31-2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #520
With this fix the Provider will not crash when trying to switch off alert grouping on a service, and also it will accept an interface more alike with the API and GUI.
Tests result:
