Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include timezdata build tag into the goreleaser config #488

Merged
merged 1 commit into from
May 18, 2022

Conversation

drastawi
Copy link
Contributor

@drastawi drastawi commented May 4, 2022

fixes #484

Following up on #478 as the time zone data should be included in the released binary. The #478 only included it in the GNUmakefile, which appears to be ignored in the release build process.

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see! This is different than the build process in the GNUMake file. Let's see if this fixes things for windows users!

@stmcallister stmcallister merged commit dd24d51 into PagerDuty:master May 18, 2022
@apollo13
Copy link

@stmcallister any chance of releasing a fixed version of this so we can test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"The system cannot find the path specified." on time_zone check in pagerduty_schedule
3 participants