Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: Validate that email integration has email #382

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

zecke
Copy link
Contributor

@zecke zecke commented Sep 6, 2021

Add validation that iff email integration is used that an email
address is specified. Make a plan only change to trigger an error
and a diff.

@zecke
Copy link
Contributor Author

zecke commented Sep 6, 2021

@stmcallister @drastawi PTAL

Copy link
Contributor

@drastawi drastawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zecke

pagerduty/resource_pagerduty_service_integration.go Outdated Show resolved Hide resolved
Add validation that iff email integration is used that an email
address is specified. Make a plan only change to trigger an error
and a diff.
@zecke zecke force-pushed the freyth/validate-integration branch from 2b33785 to f34014a Compare September 6, 2021 15:30
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@stmcallister stmcallister merged commit c228bf3 into PagerDuty:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants