-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding alert_grouping_parameters to service object #342
Conversation
Thanks for adding this @kilianw ! Will you also add a test for the new |
Integration test 'TestAccPagerDutyService_AlertContentGrouping' added separately to 'TestAccPagerDutyService_AlertGrouping' as it was failing due to HTTP 500 errors from PD. |
@kilianw It looks like |
test output: make testacc TEST=./pagerduty/ TESTARGS='-run=TestAccPagerDutyService*' |
any update on this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
what is the release policy ? I would like to use this feature so hard 🙏 |
Adding alert_grouping_parameters to service definition.
alert_grouping field got changed to 'computed: true' in the schema due to inconsistent naming when using content based routing i.e. 'rules' vs 'content_based'