Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing team resource docs #322

Merged
merged 3 commits into from
Apr 30, 2021
Merged

fixing team resource docs #322

merged 3 commits into from
Apr 30, 2021

Conversation

stmcallister
Copy link
Contributor

@stmcallister stmcallister commented Apr 7, 2021 •
edited
Loading

Missed a quotation mark when updating Team resource doc on last release. 🤦 This PR fixes that.

Corrected the listed units for the threshold_time_unit on both the pagerduty_ruleset_rule and the pagerduty_service_event_rule documents. Fixes #320

@jjm
Copy link
Contributor

jjm commented Apr 10, 2021

@stmcallister Looks good, but the PR will not close off the referenced issue as Addresses is not a valid key word (link) for closing an issue (plus it's not shown as linked to the right under linked issues).

@stmcallister
Copy link
Contributor Author

@jjm Ah! Thank you! I hadn't realized there were keywords for closing. 😅 Appreciate the tip!

@stmcallister stmcallister mentioned this pull request Apr 13, 2021
Open
@stmcallister stmcallister merged commit 274a865 into PagerDuty:master Apr 30, 2021
@stmcallister stmcallister deleted the team-doc-patch branch April 30, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobs dobs dobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for threshold_time_unit in a pagerduty_service_event_rule is wrong
3 participants
@stmcallister @jjm @dobs