Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added team to pagerduty_business_service resource #246

Merged
merged 3 commits into from
Jun 27, 2020
Merged

Added team to pagerduty_business_service resource #246

merged 3 commits into from
Jun 27, 2020

Conversation

stmcallister
Copy link
Contributor

Added the team field to the pagerduty_business_service resource.

TF_ACC=1 go test -run "TestAccPagerDutyBusinessService*" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyBusinessService_import
--- PASS: TestAccPagerDutyBusinessService_import (2.01s)
=== RUN   TestAccPagerDutyBusinessService_Basic
--- PASS: TestAccPagerDutyBusinessService_Basic (2.72s)
=== RUN   TestAccPagerDutyBusinessService_WithTeam
--- PASS: TestAccPagerDutyBusinessService_WithTeam (3.00s)
=== RUN   TestAccPagerDutyBusinessServiceDependency_Basic
--- PASS: TestAccPagerDutyBusinessServiceDependency_Basic (9.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	17.535s

Also increased retry time on Ruleset Rule Creation in attempts to help avoid collisions on the PagerDuty API.

TF_ACC=1 go test -run "TestAccPagerDutyRuleset*" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyRulesetRule_import
--- PASS: TestAccPagerDutyRulesetRule_import (5.07s)
=== RUN   TestAccPagerDutyRuleset_import
--- PASS: TestAccPagerDutyRuleset_import (4.59s)
=== RUN   TestAccPagerDutyRulesetWithNoTeam_import
--- PASS: TestAccPagerDutyRulesetWithNoTeam_import (2.01s)
=== RUN   TestAccPagerDutyRulesetRule_Basic
--- PASS: TestAccPagerDutyRulesetRule_Basic (5.59s)
=== RUN   TestAccPagerDutyRuleset_Basic
--- PASS: TestAccPagerDutyRuleset_Basic (7.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	25.397s

heimweh
heimweh approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This LGTM 🙂 👌

heimweh
heimweh reviewed Jun 23, 2020
View reviewed changes
website/docs/r/business_service.html.markdown Outdated
@@ -18,6 +18,7 @@ resource "pagerduty_business_service" "example" {
name = "My Web App"
description = "A very descriptive description of this business service"
point_of_contact = "PagerDuty Admin"
team = "P37RSRS"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run a terraform fmt against this snippet? 🙂

@stmcallister stmcallister merged commit 31b10e5 into PagerDuty:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stmcallister @heimweh