An initial implementation of client retries. #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckCrawford
changed the title
ChuckCrawford
force-pushed
the
fb/retry-support
branch
from
fbde639 to
2dd9bb6
Compare
ChuckCrawford
changed the title
Sjeanpierre
approved these changes
Mar 20, 2024
tomhart-msc
reviewed
Mar 21, 2024
tomhart-msc
reviewed
Mar 21, 2024
| return nil, respErr | ||
| } | ||
|
|
||
| if resp.StatusCode < 200 || resp.StatusCode > 299 { |
There was a problem hiding this comment.
Do we want to return 3xx as an error?
Edit: I see that's the existing behaviour. Question is not a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the ability to configure the client to retry certain types of failures.
Changes
When configured for retries:
Other Notes
Note that this functionality is not supported in the following API functions at this time:
pagerduty.CreateEventpagerduty.CreateEventWithHTTPClientclient.DoThis likely be optional functionality for the current 1.9 release. Please give us your feedback.