adding support for license and licenses allocated based operations #480 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardocorea
force-pushed
the
feature/adding-license-api-support
branch
from
49066f3 to
c35e59c
Compare
ChuckCrawford
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Thank you for putting up this PR. If we can get the method signatures reworked to properly handle the request context comment here we should be looking alright.
gerardocorea
force-pushed
the
feature/adding-license-api-support
branch
from
c35e59c to
fbacf0c
Compare
gerardocorea
force-pushed
the
feature/adding-license-api-support
branch
from
fbacf0c to
7e4fcda
Compare
Appreciate the feedback, made the requested changes. |
ChuckCrawford
approved these changes
Sep 20, 2023
gringus
pushed a commit
to gringus/go-pagerduty
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a similar approach to listing existing pagerduty resources from the pagerduty api, this PR adds the ability to list available licenses as well as licenses allocated. #480