Skip to content

Conversation

@pkuyym
Copy link
Contributor

@pkuyym pkuyym commented Feb 6, 2018

Fixes #638

@pkuyym pkuyym requested review from kuke and zhxfl February 6, 2018 09:19
Copy link
Collaborator

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

shuffle_block_num (int): Block number indicating the minimum unit to do
shuffle.
random_seed (int): Random seed.
verbose (int): Whether to suppress the complaints from sub-process. If
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't use bool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may add more verbose level for debugging.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please modify the comments, don't use Whether to ...

@pkuyym pkuyym merged commit 6759125 into PaddlePaddle:develop Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants