add dense_sequence in capi #320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcy-seso
reviewed
Sep 26, 2017
Collaborator
lcy-seso
left a comment
lcy-seso
left a comment
There was a problem hiding this comment.
Please also add a README about how to run this demo.
lcy-seso
reviewed
Sep 26, 2017
|
|
||
| # Python byte code | ||
| *.pyc | ||
|
|
| *.vcxproj | ||
| *vcxproj.* | ||
|
|
||
| # MinGW generated files |
|
|
||
| # Vim temporary files | ||
| .*.swp | ||
|
|
| @@ -0,0 +1,73 @@ | |||
| # This file is used to ignore files which are generated | |||
| #include <paddle/capi.h> | ||
| #include <time.h> | ||
|
|
||
| #include "../common/common.h" |
Collaborator
There was a problem hiding this comment.
- 这个文件在当前的目录结构下是没有的。
- 作为一个示例，请保证是自完备的。
- 需要让其他人按照readme中的步骤逐步操作便可以运行起这个例子。
- 不要让用户去猜/或者去找这些依赖在哪里。
Contributor
Author
There was a problem hiding this comment.
这里所有的capi demo都会用到 common.h 头文件，所以会放在一个单独的common目录下
| aux_source_directory(. SRC_LIST) | ||
| add_executable(${PROJECT_NAME} ${SRC_LIST}) | ||
| set_property(TARGET ${PROJECT_NAME} PROPERTY C_STANDARD 99) | ||
| target_link_libraries(${PROJECT_NAME} -lpaddle_capi_shared) |
Collaborator
There was a problem hiding this comment.
需要增加并更新一下README，否则这些动态链接库从哪里来呢 ？
Contributor
There was a problem hiding this comment.
CMakeLists.txt挺短的，是不是可以写成Makefile？
Contributor
Author
There was a problem hiding this comment.
@chengduoZH 谢谢建议，这里是按照 https://github.com/PaddlePaddle/Paddle/tree/develop/paddle/capi/examples/model_inference/dense 的形式来组织的，如果有需要可以进行调整。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #319