Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon][Fix COPY-FROM No.6-10] #6311

Merged
merged 3 commits into from
Nov 22, 2023
Merged

[Docathon][Fix COPY-FROM No.6-10] #6311

merged 3 commits into from
Nov 22, 2023

Conversation

Kaedeharai
Copy link
Contributor

@Kaedeharai Kaedeharai commented Nov 14, 2023

PR types
others

PR changes
Docs

Description
paddle.distributed.InMemoryDataset->paddle.distributed.fleet.InMemoryDataset
paddle.text.datasets.Movielens->paddle.text.Movielens
paddle.text.datasets.UCIHousing->paddle.text.UCIHousing
paddle.text.datasets.WMT14->paddle.text.WMT14
paddle.text.datasets.WMT16->paddle.text.WMT16
#6300 中文文档 copy-from 清理
@ooooo-create @sunzhongkai588

Copy link

paddle-bot bot commented Nov 14, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6311.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@@ -4,7 +4,7 @@ InMemoryDataset
-------------------------------


.. py:class:: paddle.distributed.InMemoryDataset()
.. py:class:: paddle.distributed.fleet.InMemoryDataset()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个原来是对的叭~下同
image

@@ -74,7 +74,7 @@ None。

**代码示例**

COPY-FROM: paddle.distributed.InMemoryDataset._init_distributed_settings
COPY-FROM: paddle.distributed.fleet.InMemoryDataset._init_distributed_settings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一种问题出现的地方可以通过在 中文文档官网搜索 copy-from 查看,原因是 以下划线开头的函数不会通过 import *而暴露出来,这一个api部分都可以删了叭~

@@ -3,7 +3,7 @@
Movielens
-------------------------------

.. py:class:: paddle.text.datasets.Movielens()
.. py:class:: paddle.text.Movielens()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞,是这样子改,建议把其中的参数加上,参考英文文档~
image
下同

@Kaedeharai
Copy link
Contributor Author

@ooooo-create o师傅,InMemoryDataset()这个要怎么改啊,我有点没看懂,我把那个下划线开头那部分删掉了

@ooooo-create
Copy link
Collaborator

@ooooo-create o师傅,InMemoryDataset()这个要怎么改啊,我有点没看懂,我把那个下划线开头那部分删掉了

嗯嗯,是的~就这样~~

Copy link
Collaborator

@ooooo-create ooooo-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunzhongkai588
Copy link
Collaborator

@ooooo-create o师傅,InMemoryDataset()这个要怎么改啊,我有点没看懂,我把那个下划线开头那部分删掉了

带下划线的是我们内部用法,不对外暴露,可以删掉

@luotao1 luotao1 merged commit d8dca18 into PaddlePaddle:develop Nov 22, 2023
1 check passed
@Kaedeharai Kaedeharai deleted the my-cool-stuff branch November 22, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants