-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 5th No.14】Add combinations API to Paddle #6287
Conversation
感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6287.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
提交之前,用pre-commit自动修复下文档风格
docs/api/paddle/combinations_cn.rst
Outdated
对输入 Tensor 计算长度为 r 的情况下的所有组合,当 `with_replacement` 设为True时可类比python中API `itertools.combinations` 。 | ||
而当 `with_replacement` 设为True则可类比API `itertools.combinations_with_replacement` 中参数 `with_replacement` 设为True。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 是不是写错了?应该是一个为 False 一个为 True 吧。另外语句尽量通顺一些
- 中英文之间加空格
docs/api/paddle/combinations_cn.rst
Outdated
:::::::::: | ||
- **x** (Tensor) - 输入 1-D Tensor,它的数据类型可以是 float16,float32,float64,int32,int64。 | ||
- **r** (int,可选) - 组合的数长度,默认值为 2。 | ||
- **with_replacement** (bool,可选) - 是否运行组合数中出现重复值,默认值为 False。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
写明默认值为 false 代表的含义
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add cn doc for combinations API