Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Conversation

@guochaorong
Copy link
Collaborator

No description provided.

@guochaorong guochaorong requested a review from Superjomn May 30, 2018 17:18
commits = get_commits()
kpis = {}
for commit in commits:
for commit in commits[:-self.N:-1]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要确认下这里是按时间从新往旧排序过的,取 top N 才有效

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恩恩, 确认过~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个按时间排序?最好验证下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I have added the sorting by date in this pr:
#59

@guochaorong guochaorong closed this Jun 7, 2018
@guochaorong guochaorong deleted the guochaorong-patch-5 branch June 23, 2018 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants