【Hackathon 5th No.32】为 Paddle 新增 tensor_split / hsplit / dsplit API -- v2.0 #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoooo0820
reviewed
Dec 7, 2023
| @@ -518,25 +522,27 @@ dsplit = tf_export.tf_export('experimental.numpy.dsplit', v1=[])( | |||
| - `TensorFlow`, `Numpy` 的实现方式：`split`, `vsplit`, `dsplit`, `hsplit` 为一组，都是通过 `split` (indices_or_sections) 实现，`Numpy` 单独实现了 `array_split` 函数 (indices_or_sections)。 | |||
| - `Paddle` 的实现方式：`split`, `vsplit` 为一组，都是通过 `split` (num_or_sections) 实现。 | |||
There was a problem hiding this comment.
此处以及第四章也修改一下吧
注明下方案中对vsplit做了不兼容修改
|
|
||
| 其中： | ||
|
|
||
| - `num_or_sections`, `split_size_or_sections` 数量或分片长度 | ||
| - `int` 表示拆分数量 | ||
| - `list` 表示每个分片长度 | ||
|
|
||
| - `indices_or_sections` 数量或切分索引位置 | ||
| - `num_or_indices`, `indices_or_sections` 数量或切分索引位置 | ||
| - `int` 表示拆分数量 | ||
| - `list` 表示切分的索引位置 | ||
|
|
There was a problem hiding this comment.
这个地方，可以结合前面描述的int / 数组的语义，解释下为什么命名为num_or_indices 而不直接复用pytorch/ numpy的参数命名
Update 20231208
请评审 ～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
修改
hsplit,vsplit,dsplit通过tensor_split实现。主要修改部分为
# 五、设计思路与实现方案。参考 rfc：https://github.com/PaddlePaddle/community/blob/master/rfcs/APIs/20231003_api_design_for_tensor_split.md
@zoooo0820 @jeff41404
请评审 ～ 谢谢！