Skip to content

Revert "feature/glog to exception" #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Superjomn merged 1 commit into from
Jan 9, 2018
Merged

Revert "feature/glog to exception" #72

Superjomn merged 1 commit into from
Jan 9, 2018

Conversation

@Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jan 9, 2018

Reverts #70

jacquesqiao
jacquesqiao approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit 93cfc6e into develop Jan 9, 2018
@Superjomn Superjomn deleted the revert-70-feature/glog_to_exception branch January 9, 2018 04:54
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 12, 2018
@Superjomn
Revert "feature/glog to exception" (PaddlePaddle#72)
d19f2a6
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
@Superjomn
Revert "feature/glog to exception" (PaddlePaddle#72)
04e3f0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Superjomn @jacquesqiao