Create Demo Server Target #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetfuel
reviewed
Apr 27, 2018
|
|
||
| // add hot-reload related code to entry chunks | ||
| Object.keys(baseWebpackConfig.entry).forEach(function (name) { | ||
| baseWebpackConfig.entry[name] = ['./tool/dev-client'].concat(baseWebpackConfig.entry[name]); |
Collaborator
There was a problem hiding this comment.
Not sure if we need to update the name from ./tool/dev-client to ./tool/demo-client
Collaborator
Author
There was a problem hiding this comment.
We only have dev-client.js which just includes hot-reload code.
frontend/tool/webpack.demo.config.js
Outdated
| }); | ||
|
|
||
| /** | ||
| * dev config |
frontend/tool/demo-server.js
Outdated
| _resolve = resolve; | ||
| }); | ||
|
|
||
| console.log('> Starting dev server...'); |
frontend/tool/demo-server.js
Outdated
| let express = require('express'); | ||
| let webpack = require('webpack'); | ||
| let proxyMiddleware = require('http-proxy-middleware'); | ||
| let webpackConfig = require('./webpack.dev.config'); |
Collaborator
There was a problem hiding this comment.
Here is loading the incorrect config. Should update ./webpack.dev.config to ./webpack.demo.config
jetfuel
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the demo server target shares a large amount of common code with dev server in these files:
webpack.demo.config.js
demo-server.js
start_demo_server.sh
After I gain more experiences in webpack and npm, I will try to merge the common part.
Tracking it here