Skip to content

Expand Chart should have same padding as non expand chart otherwise t… #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2018

Conversation

nickyfantasy
Copy link
Contributor

…oo much padding on expanded.

-Use fixed padding rather than percentage since width and height is always fixed.
-Add more split lines on grid when expanded

…oo much padding on expanded.

-Use fixed padding rather than percentage since width and height is always fixed.
-Add more split lines on grid when expanded
@nickyfantasy nickyfantasy requested a review from jetfuel March 15, 2018 02:27
@jetfuel
Copy link
Collaborator

jetfuel commented Mar 15, 2018

This should also apply to Histogram.

Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daming-lu daming-lu merged commit d7580a3 into PaddlePaddle:develop Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants