Skip to content

resolve frontend fecs problem #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BingBlog merged 6 commits into from
Jan 13, 2018
Merged

resolve frontend fecs problem #123

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5f4b62
modify overlay and offset chart view interplay problem
deqingli Jan 13, 2018
db41c2a
resolve frontend fecs problem
deqingli Jan 13, 2018
3960940
resolve conflict with origin repo
deqingli Jan 13, 2018
991b1d5
Merge branch 'develop' into develop
deqingli Jan 13, 2018
f909540
Merge remote-tracking branch 'origin/develop' into develop
deqingli Jan 13, 2018
66a5c56
Merge branch 'develop' of https://github.com/deqingli/VisualDL into d…
deqingli Jan 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions frontend/src/histogram/ui/chart.san
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,7 @@ export default {
series: seriesOption
};

var zr1 = this.myChart.getZr();

let zr1 = this.myChart.getZr();
zr1.on('mousemove', function (e) {
zr1.remove(zrDrawElement.hoverLine);
zr1.remove(zrDrawElement.tooltip);
Expand All @@ -193,7 +192,7 @@ export default {
grid.top = '42%';
grid.left = '4%';
grid.right = '15%';
chartData.forEach((dataItem) => {
chartData.forEach(function (dataItem) {
let lineData = [];
maxStep = Math.max(dataItem.step, maxStep);
minStep = Math.min(dataItem.step, minStep);
Expand Down Expand Up @@ -296,10 +295,10 @@ export default {
}

zrDrawElement.hoverDots = [];

let zr = ecChart.getZr();

function removeTooltip(){
function removeTooltip() {
if (zrDrawElement.hoverLine) {
zr.remove(zrDrawElement.hoverLine);
zr.remove(zrDrawElement.tooltip);
Expand All @@ -318,7 +317,7 @@ export default {
removeTooltip();
let nearestIndex = findNearestValue(e.offsetX, e.offsetY);
if (nearestIndex) {
let getCoord = function(pt) {
let getCoord = function (pt) {
return ecChart.convertToPixel('grid', pt);
};
let gridRect = ecChart.getModel().getComponent('grid', 0).coordinateSystem.getRect();
Expand Down