Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s2t] use reverse_weight in decode.yaml #2510

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

Zth9730
Copy link
Contributor

@Zth9730 Zth9730 commented Oct 9, 2022

PR types

Others

PR changes

Models

Describe

u2pp model use reverse_weight parameter in decode.yaml

@Zth9730 Zth9730 added this to the r1.3.0 milestone Oct 9, 2022
@Zth9730 Zth9730 self-assigned this Oct 9, 2022
@Zth9730 Zth9730 changed the title use reverse_weight in decode.yaml [s2t] use reverse_weight in decode.yaml Oct 9, 2022
zh794390558
zh794390558 previously approved these changes Oct 9, 2022
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yt605155624
Copy link
Collaborator

我们在很多 readme 里面都写了依赖 paddlepaddle 2.3.1 (比如 speech_server),你最好再扫一遍

Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

+ python >= 3.7
+ OS support: Linux(recommend), Windows, Mac OSX

PaddleSpeech depends on paddlepaddle. For installation, please refer to the official website of [paddlepaddle](https://www.paddlepaddle.org.cn/en) and choose according to your own machine. Here is an example of the cpu version.

```bash
pip install paddlepaddle -i https://mirror.baidu.com/pypi/simple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不修改了吧,新增一个安装develop的命令吧。

@@ -58,7 +58,7 @@ pip install pytest-runner -i https://pypi.tuna.tsinghua.edu.cn/simple
```
Then you can use the following commands:
```bash
pip install paddlepaddle -i https://mirror.baidu.com/pypi/simple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上。

@@ -117,9 +117,9 @@ conda install -y -c gcc_linux-64=8.4.0 gxx_linux-64=8.4.0
```
(Hip: Do not use the last script if you want to install by **Hard** way):
### Install PaddlePaddle
You can choose the `PaddlePaddle` version based on your system. For example, for CUDA 10.2, CuDNN7.5 install paddlepaddle-gpu 2.3.1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成已安装2.3.1版本为例,给出命令吧。要不这个得一直修改。同时写下安装develop的命令实例吧。强调下是示例。

```bash
python3 -m pip install paddlepaddle-gpu==2.3.1 -i https://mirror.baidu.com/pypi/simple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上。

@zh794390558 zh794390558 merged commit c6f9764 into PaddlePaddle:develop Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants