[Bug] Fix image read error #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyutang
requested changes
Jul 13, 2023
Comment on lines
+64
to
+66
| if img is None: | ||
| raise ValueError('Can\'t read The image file {}!'.format(data['img'])) | ||
| data['img'] = img.astype('float32') |
There was a problem hiding this comment.
这个修改会导致一个不兼容问题，目前eg1800和supervisely在调用compose时传入的是传入image，而不是string，因此这样修改会导致漏掉对image的判None操作，建议：
- 同步修改eg1800和supervisely传入path而不是image。
- 加入assert指令保证img为string类型。
- 删除if isinstance(data['img'], str)
从而所有传入的都是sting，并在加载string后进行判断是否None，不为None则astype。
There was a problem hiding this comment.
eg1800和supervisely的逻辑似乎不太方便修改为只传入string，因此多加了一个判断
Closed
Closed
shiyutang
added
Contributor PR is Merged
and removed
contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
fix #3376