Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contribs] Add CPS #3075

Merged
merged 8 commits into from
Apr 23, 2023
Merged

[Contribs] Add CPS #3075

merged 8 commits into from
Apr 23, 2023

Conversation

kongdebug
Copy link
Contributor

PR types

New features

PR changes

Contribs

Description

Add new contribs for CPS

@kongdebug kongdebug changed the title [feature] add cps contribs [Contribs] Add CPS Mar 22, 2023
@kongdebug
Copy link
Contributor Author

@Bobholamovic 晖哥有空的时候麻烦review一下

@Bobholamovic Bobholamovic self-requested a review March 23, 2023 06:03
Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

留了一些意见~

contrib/CrossPseudoSupervision/cvlibs/manager.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/cvlibs/manager.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/utils/utils.py Show resolved Hide resolved
Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

留了一些意见~

@kongdebug
Copy link
Contributor Author

留了一些意见~

好的👌,辛苦晖哥~

Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

留了一些意见,另外请留意一下我对上一次review留下的conversation的回复~

contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/datasets/cityscapes_cps.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/datasets/cityscapes_cps.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/cvlibs/builder.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/cvlibs/builder.py Outdated Show resolved Hide resolved
"""
Configuration parsing.

The following hyper-parameters are available in the config file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring与实际参数不匹配

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

留了一些意见,另外请留意一下我对上一次review留下的conversation的回复~

@kongdebug
Copy link
Contributor Author

留了一些意见,另外请留意一下我对上一次review留下的conversation的回复~

辛苦晖哥了~ 我大致看了一下 先把能改的改了

Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦修改!我注意到上一轮review中的一些意见标注了done,但好像还没有得到修改(我在本轮review中新开了一些conversation做提醒,可以不用翻找之前的review了)~ 另外,也留了一些新意见。

contrib/CrossPseudoSupervision/README.md Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/core/train.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/cvlibs/builder.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/cvlibs/builder.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/datasets/cityscapes_cps.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/models/backbones/resnet.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/core/train.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/core/train.py Outdated Show resolved Hide resolved
contrib/CrossPseudoSupervision/core/train.py Outdated Show resolved Hide resolved
Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上次review的conversation中有两处好像还没有解决


def uniform_(tensor, a, b):
"""
Modify tensor in space using uniform_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未修改


def uniform_(tensor, a, b):
"""
Modify tensor in space using uniform_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外请同步修改其它位置

Configuration parsing.

The following hyper-parameters are available in the config file:
batch_size: The number of samples total gpus.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未回复或修改

Bobholamovic
Bobholamovic previously approved these changes Apr 20, 2023
Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


## 环境配置


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分环境配置,最好明确给出目前训练验证跑通的paddle版本。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我是用脚本任务里的develop版本跑到78.39%,用2.4.0达不到这个精度,那我这里改为PaddlePaddle develop (Nightly build)版本


## 数据准备

使用CPS源代码所提供的Cityscapes数据集,下载链接为:https://pkueducn-my.sharepoint.com/:f:/g/personal/pkucxk_pku_edu_cn/EtjNKU0oVMhPkOKf9HTPlVsBIHYbACel6LSvcUeP4MXWVg?e=139icd,将数据集`city`放至`contrib/CrossPseudoSupervision/data`文件夹下,准备好的数据组织如下:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分显示存在问题,注意换行。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

contrib/CrossPseudoSupervision/README_CN.md Show resolved Hide resolved
@juncaipeng juncaipeng merged commit c71f463 into PaddlePaddle:develop Apr 23, 2023
@shiyutang shiyutang added the contributor Contribution from developers label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor Contribution from developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants