-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Contribs] Add CPS #3075
[Contribs] Add CPS #3075
Conversation
@Bobholamovic 晖哥有空的时候麻烦review一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
留了一些意见~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
留了一些意见~
好的👌,辛苦晖哥~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
留了一些意见,另外请留意一下我对上一次review留下的conversation的回复~
""" | ||
Configuration parsing. | ||
|
||
The following hyper-parameters are available in the config file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstring与实际参数不匹配
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
留了一些意见,另外请留意一下我对上一次review留下的conversation的回复~
辛苦晖哥了~ 我大致看了一下 先把能改的改了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
辛苦修改!我注意到上一轮review中的一些意见标注了done,但好像还没有得到修改(我在本轮review中新开了一些conversation做提醒,可以不用翻找之前的review了)~ 另外,也留了一些新意见。
contrib/CrossPseudoSupervision/models/losses/probohem_cross_entropy_loss.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上次review的conversation中有两处好像还没有解决
|
||
def uniform_(tensor, a, b): | ||
""" | ||
Modify tensor in space using uniform_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
未修改
|
||
def uniform_(tensor, a, b): | ||
""" | ||
Modify tensor in space using uniform_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外请同步修改其它位置
Configuration parsing. | ||
|
||
The following hyper-parameters are available in the config file: | ||
batch_size: The number of samples total gpus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
未回复或修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
||
## 环境配置 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这部分环境配置,最好明确给出目前训练验证跑通的paddle版本。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我是用脚本任务里的develop版本跑到78.39%,用2.4.0达不到这个精度,那我这里改为PaddlePaddle develop (Nightly build)
版本
|
||
## 数据准备 | ||
|
||
使用CPS源代码所提供的Cityscapes数据集,下载链接为:https://pkueducn-my.sharepoint.com/:f:/g/personal/pkucxk_pku_edu_cn/EtjNKU0oVMhPkOKf9HTPlVsBIHYbACel6LSvcUeP4MXWVg?e=139icd,将数据集`city`放至`contrib/CrossPseudoSupervision/data`文件夹下,准备好的数据组织如下: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这部分显示存在问题,注意换行。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
PR types
New features
PR changes
Contribs
Description
Add new contribs for CPS