[Enhancement] Simplify Config and Builder #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juncaipeng
changed the title
Bobholamovic
reviewed
Jan 6, 2023
There was a problem hiding this comment.
点赞！
这次解耦很彻底，算是解决了一个顽疾，我个人认为可以比肩#1719
conversation 留了一些小意见~
另外有一个想法，在此先记录：考虑到为 Buider 的子类添加类方法是很有规律的（每个组件几乎都需要经过一套相似的流程），后续可考虑用 Metaclass 简化实现。
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
简化Config和Builder，Config只保存配置信息，Builder创建各种组件。