[Enhancement] Refine User Scripts #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto refine_user_scripts_2
wuyefeilin
reviewed
Dec 15, 2022
| tmp_dic = dic | ||
| for subkey in key_list[:-1]: | ||
| tmp_dic.setdefault(subkey, dict()) | ||
| assert subkey in tmp_dic, "Can not update {}, because it is not in config.".format( |
There was a problem hiding this comment.
不允许创建新的key了吗？会不会存在默认参数原先不存在于yaml而需要传入的情况呢?
[Refactor] Decouple Classes in `config.py`
This was referenced Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description